Re: [PATCH] ASoC: tas5805m: fix pdn polarity

From: John Keeping
Date: Wed Mar 09 2022 - 07:34:45 EST


On Wed, Mar 09, 2022 at 12:12:47PM +0000, Mark Brown wrote:
> On Wed, Mar 09, 2022 at 10:41:04AM +0000, John Keeping wrote:
>
> > Fixes: ec45268467f4 ("ASoC: add support for TAS5805M digital amplifier")
>
> Please don't insert fixes tags unless you're actually fixing a bug,
> stylistic improvements like this - people try to use the tag for
> backporting bug fixes and so on so extra tags create noise for them.

This isn't purely stylistic - it affects the interpretation of pdn-gpios
in the device tree so that it matches all of the other bindings that use
this property: active means PDN asserted.

There are currently no in-tree users of the binding and the patch adding
it is queued for the next merge window.