Re: [PATCHv5.1 01/30] x86/tdx: Detect running as a TDX guest in early boot

[Borislav Petkov]

On Tue, Mar 08, 2022 at 01:24:56AM +0300, Kirill A. Shutemov wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
> 
> In preparation of extending cc_platform_has() API to support TDX guest,
> use CPUID instruction to detect support for TDX guests in the early
> boot code (via tdx_early_init()). Since copy_bootdata() is the first
> user of cc_platform_has() API, detect the TDX guest status before it.
> 
> Define a synthetic feature flag (X86_FEATURE_TDX_GUEST) and set this
> bit in a valid TDX guest platform.
> 
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
> Reviewed-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> Reviewed-by: Tony Luck <tony.luck@xxxxxxxxx>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> Acked-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> ---
>  v5.1:
>    - Drop BUILD_BUG_ON()
> ---
>  arch/x86/Kconfig                         | 12 ++++++++++++
>  arch/x86/coco/Makefile                   |  2 ++
>  arch/x86/coco/tdx.c                      | 22 ++++++++++++++++++++++
>  arch/x86/include/asm/cpufeatures.h       |  1 +
>  arch/x86/include/asm/disabled-features.h |  8 +++++++-
>  arch/x86/include/asm/tdx.h               | 21 +++++++++++++++++++++
>  arch/x86/kernel/head64.c                 |  4 ++++
>  7 files changed, 69 insertions(+), 1 deletion(-)
>  create mode 100644 arch/x86/coco/tdx.c
>  create mode 100644 arch/x86/include/asm/tdx.h

I don't know how many versions of this patch I've reviewed by now. Oh
well, finally:

Reviewed-by: Borislav Petkov <bp@xxxxxxx>

:-)

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette