Re: [PATCH 4.19 00/18] 4.19.234-rc1 review

[Daniel Díaz]

Hello!

On 09/03/22 09:59, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.234 release.
> There are 18 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 11 Mar 2022 15:58:48 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.234-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Regressions found.

The following Arm combinations failed to build:
- arm-gcc-8-bcm2835_defconfig
- arm-gcc-8-imx_v6_v7_defconfig
- arm-gcc-8-omap2plus_defconfig
- arm-gcc-9-bcm2835_defconfig
- arm-gcc-9-imx_v6_v7_defconfig
- arm-gcc-9-omap2plus_defconfig
- arm-gcc-10-bcm2835_defconfig
- arm-gcc-10-imx_v6_v7_defconfig
- arm-gcc-10-omap2plus_defconfig
- arm-gcc-11-bcm2835_defconfig
- arm-gcc-11-imx_v6_v7_defconfig
- arm-gcc-11-omap2plus_defconfig
- arm-clang-11-allnoconfig
- arm-clang-11-at91_dt_defconfig
- arm-clang-11-axm55xx_defconfig
- arm-clang-11-clps711x_defconfig
- arm-clang-11-davinci_all_defconfig
- arm-clang-11-defconfig
- arm-clang-11-exynos_defconfig
- arm-clang-11-footbridge_defconfig
- arm-clang-11-imx_v4_v5_defconfig
- arm-clang-11-imx_v6_v7_defconfig
- arm-clang-11-integrator_defconfig
- arm-clang-11-ixp4xx_defconfig
- arm-clang-11-keystone_defconfig
- arm-clang-11-lpc32xx_defconfig
- arm-clang-11-mini2440_defconfig
- arm-clang-11-multi_v5_defconfig
- arm-clang-11-mxs_defconfig
- arm-clang-11-nhk8815_defconfig
- arm-clang-11-omap1_defconfig
- arm-clang-11-omap2plus_defconfig
- arm-clang-11-orion5x_defconfig
- arm-clang-11-pxa910_defconfig
- arm-clang-11-s3c2410_defconfig
- arm-clang-11-s3c6400_defconfig
- arm-clang-11-s5pv210_defconfig
- arm-clang-11-sama5_defconfig
- arm-clang-11-shmobile_defconfig
- arm-clang-11-tinyconfig
- arm-clang-11-u8500_defconfig
- arm-clang-11-vexpress_defconfig
- arm-clang-12-allnoconfig
- arm-clang-12-at91_dt_defconfig
- arm-clang-12-axm55xx_defconfig
- arm-clang-12-clps711x_defconfig
- arm-clang-12-davinci_all_defconfig
- arm-clang-12-defconfig
- arm-clang-12-exynos_defconfig
- arm-clang-12-footbridge_defconfig
- arm-clang-12-imx_v4_v5_defconfig
- arm-clang-12-imx_v6_v7_defconfig
- arm-clang-12-integrator_defconfig
- arm-clang-12-ixp4xx_defconfig
- arm-clang-12-keystone_defconfig
- arm-clang-12-lpc32xx_defconfig
- arm-clang-12-mini2440_defconfig
- arm-clang-12-multi_v5_defconfig
- arm-clang-12-mxs_defconfig
- arm-clang-12-nhk8815_defconfig
- arm-clang-12-omap1_defconfig
- arm-clang-12-omap2plus_defconfig
- arm-clang-12-orion5x_defconfig
- arm-clang-12-pxa910_defconfig
- arm-clang-12-s3c2410_defconfig
- arm-clang-12-s3c6400_defconfig
- arm-clang-12-s5pv210_defconfig
- arm-clang-12-sama5_defconfig
- arm-clang-12-shmobile_defconfig
- arm-clang-12-tinyconfig
- arm-clang-12-u8500_defconfig
- arm-clang-12-vexpress_defconfig
- arm-clang-13-allnoconfig
- arm-clang-13-at91_dt_defconfig
- arm-clang-13-axm55xx_defconfig
- arm-clang-13-clps711x_defconfig
- arm-clang-13-davinci_all_defconfig
- arm-clang-13-defconfig
- arm-clang-13-exynos_defconfig
- arm-clang-13-footbridge_defconfig
- arm-clang-13-imx_v4_v5_defconfig
- arm-clang-13-imx_v6_v7_defconfig
- arm-clang-13-integrator_defconfig
- arm-clang-13-ixp4xx_defconfig
- arm-clang-13-keystone_defconfig
- arm-clang-13-lpc32xx_defconfig
- arm-clang-13-mini2440_defconfig
- arm-clang-13-multi_v5_defconfig
- arm-clang-13-mxs_defconfig
- arm-clang-13-nhk8815_defconfig
- arm-clang-13-omap1_defconfig
- arm-clang-13-omap2plus_defconfig
- arm-clang-13-orion5x_defconfig
- arm-clang-13-pxa910_defconfig
- arm-clang-13-s3c2410_defconfig
- arm-clang-13-s3c6400_defconfig
- arm-clang-13-s5pv210_defconfig
- arm-clang-13-sama5_defconfig
- arm-clang-13-shmobile_defconfig
- arm-clang-13-tinyconfig
- arm-clang-13-u8500_defconfig
- arm-clang-13-vexpress_defconfig
- arm-clang-14-allnoconfig
- arm-clang-14-at91_dt_defconfig
- arm-clang-14-axm55xx_defconfig
- arm-clang-14-bcm2835_defconfig
- arm-clang-14-clps711x_defconfig
- arm-clang-14-davinci_all_defconfig
- arm-clang-14-defconfig
- arm-clang-14-exynos_defconfig
- arm-clang-14-footbridge_defconfig
- arm-clang-14-imx_v4_v5_defconfig
- arm-clang-14-imx_v6_v7_defconfig
- arm-clang-14-integrator_defconfig
- arm-clang-14-ixp4xx_defconfig
- arm-clang-14-keystone_defconfig
- arm-clang-14-lpc32xx_defconfig
- arm-clang-14-mini2440_defconfig
- arm-clang-14-multi_v5_defconfig
- arm-clang-14-mxs_defconfig
- arm-clang-14-nhk8815_defconfig
- arm-clang-14-omap1_defconfig
- arm-clang-14-omap2plus_defconfig
- arm-clang-14-orion5x_defconfig
- arm-clang-14-pxa910_defconfig
- arm-clang-14-s3c2410_defconfig
- arm-clang-14-s3c6400_defconfig
- arm-clang-14-s5pv210_defconfig
- arm-clang-14-sama5_defconfig
- arm-clang-14-shmobile_defconfig
- arm-clang-14-tinyconfig
- arm-clang-14-u8500_defconfig
- arm-clang-14-vexpress_defconfig
- arm-clang-nightly-allnoconfig
- arm-clang-nightly-at91_dt_defconfig
- arm-clang-nightly-axm55xx_defconfig
- arm-clang-nightly-clps711x_defconfig
- arm-clang-nightly-davinci_all_defconfig
- arm-clang-nightly-defconfig
- arm-clang-nightly-exynos_defconfig
- arm-clang-nightly-footbridge_defconfig
- arm-clang-nightly-imx_v4_v5_defconfig
- arm-clang-nightly-imx_v6_v7_defconfig
- arm-clang-nightly-integrator_defconfig
- arm-clang-nightly-ixp4xx_defconfig
- arm-clang-nightly-keystone_defconfig
- arm-clang-nightly-lpc32xx_defconfig
- arm-clang-nightly-mini2440_defconfig
- arm-clang-nightly-multi_v5_defconfig
- arm-clang-nightly-mxs_defconfig
- arm-clang-nightly-nhk8815_defconfig
- arm-clang-nightly-omap1_defconfig
- arm-clang-nightly-omap2plus_defconfig
- arm-clang-nightly-orion5x_defconfig
- arm-clang-nightly-pxa910_defconfig
- arm-clang-nightly-s3c2410_defconfig
- arm-clang-nightly-s3c6400_defconfig
- arm-clang-nightly-s5pv210_defconfig
- arm-clang-nightly-sama5_defconfig
- arm-clang-nightly-shmobile_defconfig
- arm-clang-nightly-tinyconfig
- arm-clang-nightly-u8500_defconfig
- arm-clang-nightly-vexpress_defconfig

The Clang failures look like this (here's lpc32xx_defconfig with clang-11):

  ld.lld: error: ./arch/arm/kernel/vmlinux.lds:98: AT expected, but got NOCROSSREFS
  >>>  __vectors_lma = .; OVERLAY 0xffff0000 : NOCROSSREFS AT(__vectors_lma) { .vectors { *(.vectors) } .vectors.bhb.loop8 { *(.vectors.bhb.loop8) } .vectors.bhb.bpiall { *(.vectors.bhb.bpiall) } } __vectors_start = LOADADDR(.vectors); __vectors_end = LOADADDR(.vectors) + SIZEOF(.vectors); __vectors_bhb_loop8_start = LOADADDR(.vectors.bhb.loop8); __vectors_bhb_loop8_end = LOADADDR(.vectors.bhb.loop8) + SIZEOF(.vectors.bhb.loop8); __vectors_bhb_bpiall_start = LOADADDR(.vectors.bhb.bpiall); __vectors_bhb_bpiall_end = LOADADDR(.vectors.bhb.bpiall) + SIZEOF(.vectors.bhb.bpiall); . = __vectors_lma + SIZEOF(.vectors) + SIZEOF(.vectors.bhb.loop8) + SIZEOF(.vectors.bhb.bpiall); __stubs_lma = .; .stubs ADDR(.vectors) + 0x1000 : AT(__stubs_lma) { *(.stubs) } __stubs_start = LOADADDR(.stubs); __stubs_end = LOADADDR(.stubs) + SIZEOF(.stubs); . = __stubs_lma + SIZEOF(.stubs); PROVIDE(vector_fiq_offset = vector_fiq - ADDR(.vectors));
  >>>                                          ^
  make[1]: *** [/builds/linux/Makefile:1050: vmlinux] Error 1


A GCC failure (bcm2835_defconfig with gcc-9):

  /builds/linux/arch/arm/kernel/entry-common.S: Assembler messages:
  /builds/linux/arch/arm/kernel/entry-common.S:178: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4'
  /builds/linux/arch/arm/kernel/entry-common.S:187: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4'
  make[2]: *** [/builds/linux/scripts/Makefile.build:403: arch/arm/kernel/entry-common.o] Error 1
  /builds/linux/arch/arm/common/secure_cntvoff.S: Assembler messages:
  /builds/linux/arch/arm/common/secure_cntvoff.S:24: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4'
  /builds/linux/arch/arm/common/secure_cntvoff.S:27: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4'
  /builds/linux/arch/arm/common/secure_cntvoff.S:29: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4'
  make[2]: *** [/builds/linux/scripts/Makefile.build:403: arch/arm/common/secure_cntvoff.o] Error 1
  make[2]: Target '__build' not remade because of errors.
  make[1]: *** [/builds/linux/Makefile:1070: arch/arm/common] Error 2
  /builds/linux/arch/arm/kernel/entry-armv.S: Assembler messages:
  /builds/linux/arch/arm/kernel/entry-armv.S:1117: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4'
  /builds/linux/arch/arm/kernel/entry-armv.S:1140: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4'
  /builds/linux/arch/arm/kernel/entry-armv.S:1163: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4'
  /builds/linux/arch/arm/kernel/entry-armv.S:1186: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4'
  /builds/linux/arch/arm/kernel/entry-armv.S:1225: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4'
  make[2]: *** [/builds/linux/scripts/Makefile.build:403: arch/arm/kernel/entry-armv.o] Error 1
  /builds/linux/arch/arm/mm/cache-v7.S: Assembler messages:
  /builds/linux/arch/arm/mm/cache-v7.S:64: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4'
  /builds/linux/arch/arm/mm/cache-v7.S:137: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4'
  /builds/linux/arch/arm/mm/cache-v7.S:171: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4'
  /builds/linux/arch/arm/mm/cache-v7.S:299: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4'
  make[2]: *** [/builds/linux/scripts/Makefile.build:403: arch/arm/mm/cache-v7.o] Error 1
  /builds/linux/arch/arm/mm/tlb-v7.S: Assembler messages:
  /builds/linux/arch/arm/mm/tlb-v7.S:88: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4'
  make[2]: *** [/builds/linux/scripts/Makefile.build:403: arch/arm/mm/tlb-v7.o] Error 1
  /builds/linux/arch/arm/mm/proc-v7-2level.S: Assembler messages:
  /builds/linux/arch/arm/mm/proc-v7-2level.S:58: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4'
  /builds/linux/arch/arm/mm/proc-v7-2level.S:60: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4'
  /builds/linux/arch/arm/mm/proc-v7.S:62: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4'
  make[2]: *** [/builds/linux/scripts/Makefile.build:403: arch/arm/mm/proc-v7.o] Error 1
  make[2]: Target '__build' not remade because of errors.
  make[1]: *** [/builds/linux/Makefile:1070: arch/arm/mm] Error 2


The following x86_64/i386 combinations failed to build:
- i386-gcc-8-allnoconfig
- i386-gcc-8-i386_defconfig
- i386-gcc-8-tinyconfig
- i386-gcc-9-allnoconfig
- i386-gcc-9-i386_defconfig
- i386-gcc-9-tinyconfig
- i386-gcc-10-allnoconfig
- i386-gcc-10-defconfig
- i386-gcc-10-tinyconfig
- i386-gcc-11-allnoconfig
- i386-gcc-11-defconfig
- i386-gcc-11-tinyconfig
- x86_64-gcc-8-allnoconfig
- x86_64-gcc-8-tinyconfig
- x86_64-gcc-8-x86_64_defconfig
- x86_64-gcc-9-allnoconfig
- x86_64-gcc-9-tinyconfig
- x86_64-gcc-9-x86_64_defconfig
- x86_64-gcc-10-allnoconfig
- x86_64-gcc-10-defconfig
- x86_64-gcc-10-tinyconfig
- x86_64-gcc-11-allnoconfig
- x86_64-gcc-11-defconfig
- x86_64-gcc-11-tinyconfig
- x86_64-clang-11-allnoconfig
- x86_64-clang-11-tinyconfig
- x86_64-clang-11-x86_64_defconfig
- x86_64-clang-12-allnoconfig
- x86_64-clang-12-tinyconfig
- x86_64-clang-12-x86_64_defconfig
- x86_64-clang-13-allnoconfig
- x86_64-clang-13-tinyconfig
- x86_64-clang-13-x86_64_defconfig
- x86_64-clang-14-allnoconfig
- x86_64-clang-14-tinyconfig
- x86_64-clang-14-x86_64_defconfig
- x86_64-clang-nightly-allnoconfig
- x86_64-clang-nightly-tinyconfig
- x86_64-clang-nightly-x86_64_defconfig


An x86_64 failure (defconfig + LKFT sauce on gcc-11):

  /builds/linux/arch/x86/entry/entry_64.S: Assembler messages:
  /builds/linux/arch/x86/entry/entry_64.S:1738: Warning: no instruction mnemonic suffix given and no register operands; using default for `sysret'
  /builds/linux/arch/x86/kernel/cpu/bugs.c: In function 'spectre_v2_select_mitigation':
  /builds/linux/arch/x86/kernel/cpu/bugs.c:973:41: error: implicit declaration of function 'unprivileged_ebpf_enabled' [-Werror=implicit-function-declaration]
    973 |         if (mode == SPECTRE_V2_EIBRS && unprivileged_ebpf_enabled())
        |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~
  cc1: some warnings being treated as errors
  make[4]: *** [/builds/linux/scripts/Makefile.build:303: arch/x86/kernel/cpu/bugs.o] Error 1
  make[4]: Target '__build' not remade because of errors.
  make[3]: *** [/builds/linux/scripts/Makefile.build:544: arch/x86/kernel/cpu] Error 2
  make[3]: Target '__build' not remade because of errors.
  make[2]: *** [/builds/linux/scripts/Makefile.build:544: arch/x86/kernel] Error 2
  make[2]: Target '__build' not remade because of errors.
  make[1]: *** [/builds/linux/Makefile:1070: arch/x86] Error 2
  /builds/linux/drivers/crypto/ccp/sp-platform.c:37:34: warning: array 'sp_of_match' assumed to have one element
     37 | static const struct of_device_id sp_of_match[];
        |                                  ^~~~~~~~~~~
  /builds/linux/drivers/gpu/drm/i915/intel_dp.c: In function 'intel_dp_check_mst_status':
  /builds/linux/drivers/gpu/drm/i915/intel_dp.c:4129:30: warning: 'drm_dp_channel_eq_ok' reading 6 bytes from a region of size 4 [-Wstringop-overread]
   4129 |                             !drm_dp_channel_eq_ok(&esi[10], intel_dp->lane_count)) {
        |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /builds/linux/drivers/gpu/drm/i915/intel_dp.c:4129:30: note: referencing argument 1 of type 'const u8 *' {aka 'const unsigned char *'}
  In file included from /builds/linux/drivers/gpu/drm/i915/intel_dp.c:39:
  /builds/linux/include/drm/drm_dp_helper.h:954:6: note: in a call to function 'drm_dp_channel_eq_ok'
    954 | bool drm_dp_channel_eq_ok(const u8 link_status[DP_LINK_STATUS_SIZE],
        |      ^~~~~~~~~~~~~~~~~~~~
  make[1]: Target '_all' not remade because of errors.
  make: *** [Makefile:146: sub-make] Error 2


And a similar i386 failure (defconfig + LKFT sauce on gcc-11):

  /builds/linux/arch/x86/kernel/cpu/bugs.c: In function 'spectre_v2_select_mitigation':
  /builds/linux/arch/x86/kernel/cpu/bugs.c:973:41: error: implicit declaration of function 'unprivileged_ebpf_enabled' [-Werror=implicit-function-declaration]
    973 |         if (mode == SPECTRE_V2_EIBRS && unprivileged_ebpf_enabled())
        |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~
  cc1: some warnings being treated as errors
  make[4]: *** [/builds/linux/scripts/Makefile.build:303: arch/x86/kernel/cpu/bugs.o] Error 1
  make[4]: Target '__build' not remade because of errors.
  make[3]: *** [/builds/linux/scripts/Makefile.build:544: arch/x86/kernel/cpu] Error 2
  make[3]: Target '__build' not remade because of errors.
  make[2]: *** [/builds/linux/scripts/Makefile.build:544: arch/x86/kernel] Error 2
  make[2]: Target '__build' not remade because of errors.
  make[1]: *** [/builds/linux/Makefile:1070: arch/x86] Error 2
  /builds/linux/drivers/crypto/ccp/sp-platform.c:37:34: warning: array 'sp_of_match' assumed to have one element
     37 | static const struct of_device_id sp_of_match[];
        |                                  ^~~~~~~~~~~
  /builds/linux/drivers/gpu/drm/i915/intel_dp.c: In function 'intel_dp_check_mst_status':
  /builds/linux/drivers/gpu/drm/i915/intel_dp.c:4129:30: warning: 'drm_dp_channel_eq_ok' reading 6 bytes from a region of size 4 [-Wstringop-overread]
   4129 |                             !drm_dp_channel_eq_ok(&esi[10], intel_dp->lane_count)) {
        |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /builds/linux/drivers/gpu/drm/i915/intel_dp.c:4129:30: note: referencing argument 1 of type 'const u8 *' {aka 'const unsigned char *'}
  In file included from /builds/linux/drivers/gpu/drm/i915/intel_dp.c:39:
  /builds/linux/include/drm/drm_dp_helper.h:954:6: note: in a call to function 'drm_dp_channel_eq_ok'
    954 | bool drm_dp_channel_eq_ok(const u8 link_status[DP_LINK_STATUS_SIZE],
        |      ^~~~~~~~~~~~~~~~~~~~
  make[1]: Target '_all' not remade because of errors.
  make: *** [Makefile:146: sub-make] Error 2


Greetings!

Daniel Díaz
daniel.diaz@xxxxxxxxxx