Re: [PATCH] mm: Only re-generate demotion targets when a numa node changes its N_CPU state

[Oscar Salvador]

On Wed, Mar 09, 2022 at 01:02:49PM -0800, Andrew Morton wrote:
> On Wed,  9 Mar 2022 15:46:44 +0100 Oscar Salvador <osalvador@xxxxxxx> wrote:
> > +static inline void set_migration_target_nodes() {}
> 
> Compiler won't like that.  Please test (compile and runtime) with
> CONFIG_HOTPLUG_CPU=n.

Sorry, fat fingers. This on top:

diff --git a/include/linux/migrate.h b/include/linux/migrate.h
index c64fe2923fb0..b82b4a9a0136 100644
--- a/include/linux/migrate.h
+++ b/include/linux/migrate.h
@@ -51,7 +51,7 @@ extern bool numa_demotion_enabled;
 #ifdef CONFIG_HOTPLUG_CPU
 extern void set_migration_target_nodes(void);
 #else
-static inline void set_migration_target_nodes() {}
+static inline void set_migration_target_nodes(void) {}
 #endif
 #else

I will wait for some feedback before sending a v2.

thanks Andrew!

-- 
Oscar Salvador
SUSE Labs