Re: [PATCH v4 10/24] EDAC/amd64: Define function to get Interleave Address Bit

From: Yazen Ghannam
Date: Wed Mar 09 2022 - 17:12:25 EST


On Mon, Feb 14, 2022 at 01:10:49PM +0100, Borislav Petkov wrote:
> On Thu, Jan 27, 2022 at 08:41:01PM +0000, Yazen Ghannam wrote:
> > Move code to find the interleave address bit into a separate helper
> > function.
>
> Same question: what's the point of this change?
>

Yes, I'll update this.

Similar goal as in other places. When the function seems sufficiently long
(subjective I know), break it up into helper functions.

I've been trying to decide based on logical steps. Do you have any general
recommendations or rule-of-thumb?

Thanks,
Yazen