Re: [PATCH 04/13] ptrace: Remove arch_syscall_{enter,exit}_tracehook

From: Kees Cook
Date: Wed Mar 09 2022 - 17:29:13 EST


On Wed, Mar 09, 2022 at 10:24:45AM -0600, Eric W. Biederman wrote:
> These functions are alwasy one-to-one wrappers around
> ptrace_report_syscall_entry and ptrace_report_syscall_exit.
> So directly call the functions they are wrapping instead.
>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
> ---
> include/linux/entry-common.h | 43 ++----------------------------------
> kernel/entry/common.c | 4 ++--
> 2 files changed, 4 insertions(+), 43 deletions(-)

nit: This should maybe talk about how this is just removing needless
indirection in the common entry code?

Regardless:

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

--
Kees Cook