[davidhildenbrand:cow_fixes_part_3 23/37] mm/gup.c:2555:17: error: label 'pte_unmap' used but not defined

From: kernel test robot
Date: Wed Mar 09 2022 - 19:47:11 EST


tree: git://github.com/davidhildenbrand/linux cow_fixes_part_3
head: d49a3c40226a6bb397e7c532c81eb7d91026acaf
commit: f88e4c489908eb7ca8f63ea3dae1b09febcff282 [23/37] mm/gup: trigger FAULT_FLAG_UNSHARE when R/O-pinning a possibly shared anonymous page
config: powerpc64-buildonly-randconfig-r004-20220309 (https://download.01.org/0day-ci/archive/20220310/202203100823.mNsrrOHO-lkp@xxxxxxxxx/config)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/davidhildenbrand/linux/commit/f88e4c489908eb7ca8f63ea3dae1b09febcff282
git remote add davidhildenbrand git://github.com/davidhildenbrand/linux
git fetch --no-tags davidhildenbrand cow_fixes_part_3
git checkout f88e4c489908eb7ca8f63ea3dae1b09febcff282
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

mm/gup.c: In function 'gup_hugepte':
>> mm/gup.c:2555:17: error: label 'pte_unmap' used but not defined
2555 | goto pte_unmap;
| ^~~~


vim +/pte_unmap +2555 mm/gup.c

2518
2519 static int gup_hugepte(pte_t *ptep, unsigned long sz, unsigned long addr,
2520 unsigned long end, unsigned int flags,
2521 struct page **pages, int *nr)
2522 {
2523 unsigned long pte_end;
2524 struct page *head, *page;
2525 pte_t pte;
2526 int refs;
2527
2528 pte_end = (addr + sz) & ~(sz-1);
2529 if (pte_end < end)
2530 end = pte_end;
2531
2532 pte = huge_ptep_get(ptep);
2533
2534 if (!pte_access_permitted(pte, flags & FOLL_WRITE))
2535 return 0;
2536
2537 /* hugepages are never "special" */
2538 VM_BUG_ON(!pfn_valid(pte_pfn(pte)));
2539
2540 head = pte_page(pte);
2541 page = head + ((addr & (sz-1)) >> PAGE_SHIFT);
2542 refs = record_subpages(page, addr, end, pages + *nr);
2543
2544 head = try_grab_compound_head(head, refs, flags);
2545 if (!head)
2546 return 0;
2547
2548 if (unlikely(pte_val(pte) != pte_val(*ptep))) {
2549 put_compound_head(head, refs, flags);
2550 return 0;
2551 }
2552
2553 if (!pte_write(pte) && gup_must_unshare(flags, head)) {
2554 put_compound_head(head, refs, flags);
> 2555 goto pte_unmap;
2556 }
2557
2558 *nr += refs;
2559 SetPageReferenced(head);
2560 return 1;
2561 }
2562

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx