Re: [PATCH] mm: Only re-generate demotion targets when a numa node changes its N_CPU state

From: kernel test robot
Date: Wed Mar 09 2022 - 20:18:36 EST


Hi Oscar,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on hnaz-mm/master]

url: https://github.com/0day-ci/linux/commits/Oscar-Salvador/mm-Only-re-generate-demotion-targets-when-a-numa-node-changes-its-N_CPU-state/20220309-224707
base: https://github.com/hnaz/linux-mm master
config: riscv-randconfig-s032-20220309 (https://download.01.org/0day-ci/archive/20220310/202203100900.4UKi7486-lkp@xxxxxxxxx/config)
compiler: riscv32-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/8af0c9ff9475c64e31963a5810b127875081c5ff
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Oscar-Salvador/mm-Only-re-generate-demotion-targets-when-a-numa-node-changes-its-N_CPU-state/20220309-224707
git checkout 8af0c9ff9475c64e31963a5810b127875081c5ff
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=riscv SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

mm/vmstat.c: In function 'vmstat_cpu_online':
>> mm/vmstat.c:2056:17: error: implicit declaration of function 'set_migration_target_nodes' [-Werror=implicit-function-declaration]
2056 | set_migration_target_nodes();
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors


vim +/set_migration_target_nodes +2056 mm/vmstat.c

2049
2050 static int vmstat_cpu_online(unsigned int cpu)
2051 {
2052 refresh_zone_stat_thresholds();
2053
2054 if (!node_state(cpu_to_node(cpu), N_CPU)) {
2055 node_set_state(cpu_to_node(cpu), N_CPU);
> 2056 set_migration_target_nodes();
2057 }
2058
2059 return 0;
2060 }
2061

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx