Re: [PATCH v2 01/19] fscache: export fscache_end_operation()

From: JeffleXu
Date: Wed Mar 09 2022 - 20:40:33 EST




On 3/9/22 11:26 PM, Jeff Layton wrote:
> On Tue, 2022-03-08 at 23:25 +0000, David Howells wrote:
>> From: Jeffle Xu <jefflexu@xxxxxxxxxxxxxxxxx>
>>
>> Export fscache_end_operation() to avoid code duplication.
>>
>> Besides, considering the paired fscache_begin_read_operation() is
>> already exported, it shall make sense to also export
>> fscache_end_operation().
>>
>
> Not what I think of when you say "exporting" but the patch itself looks
> fine.
>

Yes, maybe "fscache: make fscache_end_operation() generally available"
as David said shall be better...

--
Thanks,
Jeffle