Re: [PATCH 2/3] thermal: artpec8-tmu: Add tmu driver for artpec8

[Krzysztof Kozlowski]

On 10/03/2022 02:57, Sang Min Kim wrote:
>  
> Add tmu driver to handle thermal management for artpec8 SoC.
>  
> This driver is derived from the tmu of exynos and additionally supports
> the thermal zone of multiple remote sensors of artpec8.
>  
> Signed-off-by: sangmin kim <hypmean.kim@xxxxxxxxxxx>
> ---
>  drivers/thermal/samsung/artpec8_tmu.c | 754 ++++++++++++++++++++++++++++++++++
>  1 file changed, 754 insertions(+)
>  create mode 100644 drivers/thermal/samsung/artpec8_tmu.c
>  
> diff --git a/drivers/thermal/samsung/artpec8_tmu.c b/drivers/thermal/samsung/artpec8_tmu.c
> new file mode 100644
> index 0000000..d973827
> --- /dev/null
> +++ b/drivers/thermal/samsung/artpec8_tmu.c
> @@ -0,0 +1,754 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + *  artpec8_tmu.c - Samsung TMU (Thermal Management Unit)
> + *
> + *  Copyright (C) 2014 Samsung Electronics
> + *  Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> + *  Lukasz Majewski <l.majewski@xxxxxxxxxxx>
> + *
> + *  Copyright (C) 2011 Samsung Electronics
> + *  Donggeun Kim <dg77.kim@xxxxxxxxxxx>
> + *  Amit Daniel Kachhap <amit.kachhap@xxxxxxxxxx>
> + */
> +

This does not look like a need for a new driver. Please extend existing
one. Quickly going through the source code also supports it - no need
for new driver.


Best regards,
Krzysztof