RE: [PATCH net v2] gianfar: ethtool: Fix refcount leak in gfar_get_ts_info

From: Claudiu Manoil
Date: Thu Mar 10 2022 - 02:24:13 EST


> -----Original Message-----
> From: Miaoqian Lin <linmq006@xxxxxxxxx>
> Sent: Thursday, March 10, 2022 3:53 AM
> To: Claudiu Manoil <claudiu.manoil@xxxxxxx>; David S. Miller
> <davem@xxxxxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Y.B. Lu
> <yangbo.lu@xxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Cc: linmq006@xxxxxxxxx
> Subject: [PATCH net v2] gianfar: ethtool: Fix refcount leak in gfar_get_ts_info
>
> The of_find_compatible_node() function returns a node pointer with
> refcount incremented, We should use of_node_put() on it when done
> Add the missing of_node_put() to release the refcount.
>
> Fixes: 7349a74ea75c ("net: ethernet: gianfar_ethtool: get phc index through
> drvdata")
> Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>
> ---
> changes in v2:
> - Fix the subject
> ---

Reviewed-by: Claudiu Manoil <claudiu.manoil@xxxxxxx>