Re: [PATCH] tty: serial: bcm63xx: use more precise Kconfig symbol

[Rafał Miłecki]

On 10.03.2022 09:19, Geert Uytterhoeven wrote:
> On Thu, Mar 10, 2022 at 8:22 AM Rafał Miłecki <zajec5@xxxxxxxxx> wrote:
> > From: Rafał Miłecki <rafal@xxxxxxxxxx>
> >
> > Patches lowering SERIAL_BCM63XX dependencies led to a discussion and
> > documentation change regarding "depends" usage. Adjust Kconfig entry to
> > match current guidelines. Make this symbol available for relevant
> > architectures only.
> >
> > Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > Ref: f35a07f92616 ("tty: serial: bcm63xx: lower driver dependencies")
> > Ref: 18084e435ff6 ("Documentation/kbuild: Document platform dependency practises")
> > Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/drivers/tty/serial/Kconfig
> > +++ b/drivers/tty/serial/Kconfig
> > @@ -1100,7 +1100,8 @@ config SERIAL_TIMBERDALE
> >   config SERIAL_BCM63XX
> >          tristate "Broadcom BCM63xx/BCM33xx UART support"
> >          select SERIAL_CORE
> > -       depends on COMMON_CLK
> > +       depends on MIPS || ARM || ARM64 || COMPILE_TEST
> > +       default ARCH_BCM4908 || BCM63XX || BMIPS_GENERIC
>
> So ARCH_BCM4908 covers ARM64, and BCM63XX || BMIPS_GENERIC
> cover MIPS.  Is there some symbol covering ARM so we can change the
> depends to
>
>      depends on FOO || ARCH_BCM4908 || BCM63XX || BMIPS_GENERIC || COMPILE_TEST
>
> ?

Florian, Kevin: do you know what other platforms need that driver?

Ref: c0ec3fd123e9 ("tty: serial: bcm63xx: Allow bcm63xx_uart to be built on other platforms")
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c0ec3fd123e9e64e095fb221ace841e00c04e40b