Re: [PATCH 0/2] vsock: cycle only on its own socket

From: Michael S. Tsirkin
Date: Thu Mar 10 2022 - 07:59:28 EST


On Thu, Mar 10, 2022 at 07:57:58AM -0500, Michael S. Tsirkin wrote:
> On Thu, Mar 10, 2022 at 09:54:23PM +0900, Jiyong Park wrote:
> > Hi Stefano,
> >
> > As suggested [1], I've made two patches for easier backporting without
> > breaking KMI.
> >
> > PATCH 1 fixes the very issue of cycling all vsocks regardless of the
> > transport and shall be backported.
> >
> > PATCH 2 is a refactor of PATCH 1 that forces the filtering to all
> > (including future) uses of vsock_for_each_connected_socket.
> >
> > Thanks,
> >
> > [1] https://lore.kernel.org/lkml/20220310110036.fgy323c4hvk3mziq@sgarzare-redhat/
>
>
> OK that's better. Pls do include changelog in the future.
>
> Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx>

Hmm actually I think I have a better idea. Hang on.

>
>
> > Jiyong Park (2):
> > vsock: each transport cycles only on its own sockets
> > vsock: refactor vsock_for_each_connected_socket
> >
> > drivers/vhost/vsock.c | 3 ++-
> > include/net/af_vsock.h | 3 ++-
> > net/vmw_vsock/af_vsock.c | 9 +++++++--
> > net/vmw_vsock/virtio_transport.c | 7 +++++--
> > net/vmw_vsock/vmci_transport.c | 3 ++-
> > 5 files changed, 18 insertions(+), 7 deletions(-)
> >
> >
> > base-commit: 3bf7edc84a9eb4007dd9a0cb8878a7e1d5ec6a3b
> > --
> > 2.35.1.723.g4982287a31-goog