Re: [PATCH] ax25: Fix memory leaks caused by ax25_cb_del()

From: Dan Carpenter
Date: Thu Mar 10 2022 - 08:05:46 EST


This is a very frustrating patch because you make a lot of unnecessary
white space changes and you didn't run checkpatch on your patch.

The whole approach feels like the wrong thing...

I have read your commit message, but I don't understand why we can't
just use normal refcounting. It sounds like there is a layering
violation somewhere?

Even if we go with this approach ->kill_flag and ->bind_flag should be
booleans. It makes no sense to have a unsigned long where only BIT(2)
can be set.

regards,
dan carpenter