Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671

[Takashi Iwai]

On Thu, 10 Mar 2022 14:03:01 +0100,
huangwenhui wrote:
> 
> On a HP 288 Pro G8, the front Mic could not be detected.
> 
> Signed-off-by: huangwenhui <huangwenhuia@xxxxxxxxxxxxx>

Thanks for the patch.  Most of the changes look OK, but one thing I
still don't get:

> +	case HDA_FIXUP_ACT_INIT:
> +		alc_write_coef_idx(codec, 0x19, 0xa054);
> +		msleep(80);
> +		snd_hda_codec_write(codec, hp_pin, 0,
> +			    AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE);

Why this unconditional unmute is required for fixing the mic problem?


Takashi