Re: [PATCHv5 02/30] x86/tdx: Provide common base for SEAMCALL and TDCALL C wrappers

From: Kirill A. Shutemov
Date: Thu Mar 10 2022 - 09:55:03 EST


On Thu, Mar 10, 2022 at 01:32:40PM +0100, Borislav Petkov wrote:
> On Wed, Mar 02, 2022 at 05:27:38PM +0300, Kirill A. Shutemov wrote:
> > arch/x86/include/asm/tdx.h | 28 +++++++++++
> > arch/x86/kernel/asm-offsets.c | 9 ++++
> > arch/x86/virt/tdxcall.S | 95 +++++++++++++++++++++++++++++++++++
>
> Right, you asked already about putting this under arch/x86/virt/ but on
> a second thought, this doesn't look like
>
> "- generic host virtualization stuff: arch/x86/virt/"
>
> to me:
>
> https://lore.kernel.org/r/Yg5nh1RknPRwIrb8@xxxxxxx
>
> Rather, this looks like it wants to be under
>
> arch/x86/virt/vmx/tdx/
>
> where we said that this should be the coco host code place.

I'm fine moving where you want. But I want to make sure we are on the same
page: this code is common for guest and host TDX. I think VMX referes more
to host side of the thing, no?

--
Kirill A. Shutemov