Re: [PATCH] bpf: test_run: use kvfree() for memory allocated with kvmalloc()

[Daniel Borkmann]

[ You have plenty of folks in Cc, just not Toke given b530e9e1063e, so added him. ;) ]

On 3/10/22 10:28 AM, Yihao Han wrote:
> It is allocated with kvmalloc(), the corresponding release function
> should not be kfree(), use vfree() instead.

nit: s/vfree/kvfree/

> Generated by: scripts/coccinelle/api/kfree_mismatch.cocci

Fixed up typo and added Fixes tag before pushing, thanks!

> Signed-off-by: Yihao Han <hanyihao@xxxxxxxx>
> ---
>   net/bpf/test_run.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/bpf/test_run.c b/net/bpf/test_run.c
> index 25169908be4a..b7e1e5f61c50 100644
> --- a/net/bpf/test_run.c
> +++ b/net/bpf/test_run.c
> @@ -196,9 +196,9 @@ static int xdp_test_run_setup(struct xdp_test_data *xdp, struct xdp_buff *orig_c
>   err_mmodel:
>   	page_pool_destroy(pp);
>   err_pp:
> -	kfree(xdp->skbs);
> +	kvfree(xdp->skbs);
>   err_skbs:
> -	kfree(xdp->frames);
> +	kvfree(xdp->frames);
>   	return err;
>   }
>