Re: [PATCH v3 2/7] dt-bindings: interrupt-controller: apple,aic2: New binding for AICv2

From: Rob Herring
Date: Thu Mar 10 2022 - 10:43:27 EST


On Thu, Mar 10, 2022 at 04:21:18AM +0900, Hector Martin wrote:
> This new incompatible revision of the AIC peripheral introduces
> multi-die support. This binding is based on apple,aic, but
> changes interrupt-cells to add a new die argument.
>
> Also adds a second reg entry to specify the offset of the event
> register. Inexplicably, the capability registers allow us to compute
> other register offsets, but not this one. This allows us to keep
> forward-compatibility with future SoCs that will likely implement
> different die counts, thus shifting the event register. Apple also
> specify the offset explicitly in their their device tree...

their their

(checkpatch with codespell installed told me)

>
> Signed-off-by: Hector Martin <marcan@xxxxxxxxx>
> ---
> .../interrupt-controller/apple,aic2.yaml | 98 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 2 files changed, 99 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml

With that,

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>