Re: [PATCH] ath10k: Fix error handling in ath10k_setup_msa_resources
From: Kalle Valo
Date: Thu Mar 10 2022 - 10:53:03 EST
Miaoqian Lin <linmq006@xxxxxxxxx> wrote:
> The device_node pointer is returned by of_parse_phandle() with refcount
> incremented. We should use of_node_put() on it when done.
>
> This function only calls of_node_put() in the regular path.
> And it will cause refcount leak in error path.
>
> Fixes: 727fec790ead ("ath10k: Setup the msa resources before qmi init")
> Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
> Reviewed-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
> Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx>
Patch applied to ath-next branch of ath.git, thanks.
9747a78d5f75 ath10k: Fix error handling in ath10k_setup_msa_resources
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220308070238.19295-1-linmq006@xxxxxxxxx/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches