Re: [PATCH] brcmfmac: check the return value of devm_kzalloc() in brcmf_of_probe()

[Kalle Valo]

Jia-Ju Bai <baijiaju1990@xxxxxxxxx> wrote:

> The function devm_kzalloc() in brcmf_of_probe() can fail, so its return
> value should be checked.
> 
> Fixes: 29e354ebeeec ("brcmfmac: Transform compatible string for FW loading")
> Reported-by: TOTE Robot <oslab@xxxxxxxxxxxxxxx>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@xxxxxxxxx>

You are not calling of_node_put() in the error path. And I don't think
this even applies.

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220225132138.27722-1-baijiaju1990@xxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches