Re: [PATCH] ethtool: Fix refcount leak in gfar_get_ts_info

From: Jakub Kicinski
Date: Thu Mar 10 2022 - 15:37:02 EST


On Thu, 10 Mar 2022 20:30:10 +0000 patchwork-bot+netdevbpf@xxxxxxxxxx
wrote:
> Hello:
>
> This patch was applied to netdev/net.git (master)
> by Jakub Kicinski <kuba@xxxxxxxxxx>:

No, it wasn't. Maybe I forgot to mark this version as Changes Requested
before applying v2.

> On Wed, 9 Mar 2022 09:11:49 +0000 you wrote:
> > The of_find_compatible_node() function returns a node pointer with
> > refcount incremented, We should use of_node_put() on it when done
> > Add the missing of_node_put() to release the refcount.
> >
> > Fixes: 7349a74ea75c ("net: ethernet: gianfar_ethtool: get phc index through drvdata")
> > Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
> >
> > [...]
>
> Here is the summary with links:
> - ethtool: Fix refcount leak in gfar_get_ts_info
> https://git.kernel.org/netdev/net/c/2ac5b58e645c
>
> You are awesome, thank you!