Re: [PATCH v2 0/2] drm/bridge: analogix_dp: Self-refresh state machine fixes

From: Brian Norris
Date: Thu Mar 10 2022 - 18:50:26 EST


On Mon, Feb 28, 2022 at 12:25 PM Brian Norris <briannorris@xxxxxxxxxxxx> wrote:
>
> Hi,
>
> I've been investigating several eDP issues on a Rockchip RK3399 system
> and have two proposed bugfixes. RK3399 has two CRTCs, either of which
> can be used for eDP output. For both fixes, we have bugs due to the
> relationship between the generalized "self refresh helpers" and the
> analogix-dp bridge driver which controls much of the PSR mechanics.
> These bugs are most visible when switching between CRTCs.
>
> I'm not a DRM expert, but I've been poking at a lot of Rockchip display
> drivers recently. I'd love some skeptical eyes, so feel free to ask
> questions if I haven't explained issues well, or the proposals look
> fishy.
>
> Regards,
> Brian

Ping for review? Sean, perhaps? (You already reviewed this on the
Chromium tracker.)

Brian