Re: [PATCH 1/2] bpf: Adjust BPF stack helper functions to accommodate skip > 0

[Namhyung Kim]

Hi Hao,

On Thu, Mar 10, 2022 at 4:24 PM Hao Luo <haoluo@xxxxxxxxxx> wrote:
> > > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> > > index b0383d371b9a..77f4a022c60c 100644
> > > --- a/include/uapi/linux/bpf.h
> > > +++ b/include/uapi/linux/bpf.h
> > > @@ -2975,8 +2975,8 @@ union bpf_attr {
> > >    *
> > >    *                  # sysctl kernel.perf_event_max_stack=<new value>
> > >    *  Return
> > > - *           A non-negative value equal to or less than *size* on success,
> > > - *           or a negative error in case of failure.
> > > + *           The non-negative copied *buf* length equal to or less than
> > > + *           *size* on success, or a negative error in case of failure.
> > >    *
> > >    * long bpf_skb_load_bytes_relative(const void *skb, u32 offset, void *to, u32 len, u32 start_header)
>
> Namhyung, I think you also need to mirror the change in
> tools/include/uapi/linux/bpf.h

Oh, right.  Will update.

Thanks,
Namhyung