Re: [PATCH v2] mm/hmm/test: simplify hmm test code: use miscdevice instead of char dev

[Mika Penttilä]

On 11.3.2022 8.15, John Hubbard wrote:
> On 3/10/22 19:30, mpenttil@xxxxxxxxxx wrote:
> > From: Mika Penttilä <mpenttil@xxxxxxxxxx>
> >
> > HMM selftests use an in-kernel pseudo device to emulate device private
> > memory. The pseudo device registers a major device range for two pseudo
> > device instances. User space has a script that reads /proc/devices in
> > order to find the assigned major number, and sends that to mknod(1),
> > once for each node.
> >
> > This duplicates a fair amount of boilerplate that misc device can do
> > instead.
> >
> > Change this to use misc device, which makes the device node names appear
> > for us. This also enables udev-like processing if desired.
> >
> > Delete the /proc/devices parsing from the user-space test script, now
> > that it is unnecessary.
> >
> > v2:
> >          - Cleanups per review comments from John Hubbard
> >          - Added Tested-by and Ccs
>
> The three lines above, starting with "v2:", belong after the "---". That
> way, they are not included in the commit log. That's the convention.
>
> I think Andrew can fix it up for you, no need to spin a new patch for
> that.
>
> Anyway, this looks good now, so please feel free to add:
>
> Reviewed-by: John Hubbard <jhubbard@xxxxxxxxxx>


Thanks John!

> thanks,