Re: [PATCH v4] drivers: ddcci: upstream DDCCI driver

[gregkh]

On Thu, Mar 10, 2022 at 05:19:47PM -0800, Yusuf Khan wrote:
> I (hopefully) fulfilled those requests in my subsequent patch,
> turns out I forgot to git add some of my changes. I did not
> remove the unlikely()s  as I think they look good and point
> to where error checking is that many may miss.

Never use a unlikely() or likely() macro unless you can prove, with a
benchmark, that it makes the code go faster.  If not, just remove them
as the compiler and CPU will always do a better job at this (we have
proof of it in the past.)

thanks,

greg k-h