Re: [PATCH v1 1/3] dts: add Nuvoton sgpio feature

From: Krzysztof Kozlowski
Date: Fri Mar 11 2022 - 04:18:36 EST


On 11/03/2022 07:09, jimliu2 wrote:
> add Nuvoton sgpio feature
>
> Signed-off-by: jimliu2 <JJLIU0@xxxxxxxxxxx>
> ---
> arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
> index 3696980a3da1..58f4b463c745 100644
> --- a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
> +++ b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
> @@ -329,6 +329,36 @@
> status = "disabled";
> };
>
> + sgpio1: sgpio@101000 {

Generic node name.

> + clocks = <&clk NPCM7XX_CLK_APB3>;
> + compatible = "nuvoton,npcm750-sgpio";
> + interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&iox1_pins>;
> + bus-frequency = <16000000>;
> + nin_gpios = <64>;
> + nout_gpios = <64>;
> + reg = <0x101000 0x200>;

In each node first goes compatible, then reg.

Best regards,
Krzysztof