Re: [PATCH 3/3] serial: 8250_fintek.c: Clean up set_termios() message

[Jiri Slaby]

On 11. 03. 22, 8:02, Trevor Woerner wrote:
> Clean up the status message that is given in the case where a custom
> termios() is not installed.
>
> Signed-off-by: Trevor Woerner <twoerner@xxxxxxxxx>
> ---
>   drivers/tty/serial/8250/8250_fintek.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_fintek.c b/drivers/tty/serial/8250/8250_fintek.c
> index 03ad2354d808..dcab23d1965e 100644
> --- a/drivers/tty/serial/8250/8250_fintek.c
> +++ b/drivers/tty/serial/8250/8250_fintek.c
> @@ -333,7 +333,7 @@ static void fintek_8250_set_termios(struct uart_port *port,
>   	default:
>   		/* Don't change clocksource with unknown PID */
>   		dev_warn(port->dev,
> -			"%s: pid: %x Not support. use default set_termios.\n",
> +			"%s: chipID: %x not supported; using default set_termios.\n",
>   			__func__, pdata->pid);

So the variable calls it PID, the comment calls it PID and you change 
the report to chipID. Why?

thanks,
--
js
suse labs