Re: [PATCH v9 14/14] mm: multi-gen LRU: design doc

From: Yu Zhao
Date: Fri Mar 11 2022 - 04:39:04 EST


On Fri, Mar 11, 2022 at 1:23 AM Mike Rapoport <rppt@xxxxxxxxxx> wrote:
>
> On Tue, Mar 08, 2022 at 07:12:31PM -0700, Yu Zhao wrote:
> > Add a design doc.
> >
> > Signed-off-by: Yu Zhao <yuzhao@xxxxxxxxxx>
> > Acked-by: Brian Geffon <bgeffon@xxxxxxxxxx>
> > Acked-by: Jan Alexander Steffens (heftig) <heftig@xxxxxxxxxxxxx>
> > Acked-by: Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx>
> > Acked-by: Steven Barrett <steven@xxxxxxxxxxxx>
> > Acked-by: Suleiman Souhlal <suleiman@xxxxxxxxxx>
> > Tested-by: Daniel Byrne <djbyrne@xxxxxxx>
> > Tested-by: Donald Carr <d@xxxxxxxxxxxxxxx>
> > Tested-by: Holger Hoffstätte <holger@xxxxxxxxxxxxxxxxxxxxxx>
> > Tested-by: Konstantin Kharlamov <Hi-Angel@xxxxxxxxx>
> > Tested-by: Shuang Zhai <szhai2@xxxxxxxxxxxxxxxx>
> > Tested-by: Sofia Trinh <sofia.trinh@edi.works>
> > Tested-by: Vaibhav Jain <vaibhav@xxxxxxxxxxxxx>
> > ---
> > Documentation/vm/index.rst | 1 +
> > Documentation/vm/multigen_lru.rst | 156 ++++++++++++++++++++++++++++++
> > 2 files changed, 157 insertions(+)
> > create mode 100644 Documentation/vm/multigen_lru.rst
> >
> > diff --git a/Documentation/vm/index.rst b/Documentation/vm/index.rst
> > index 44365c4574a3..b48434300226 100644
> > --- a/Documentation/vm/index.rst
> > +++ b/Documentation/vm/index.rst
> > @@ -25,6 +25,7 @@ algorithms. If you are looking for advice on simply allocating memory, see the
> > ksm
> > memory-model
> > mmu_notifier
> > + multigen_lru
> > numa
> > overcommit-accounting
> > page_migration
> > diff --git a/Documentation/vm/multigen_lru.rst b/Documentation/vm/multigen_lru.rst
> > new file mode 100644
> > index 000000000000..cde60de16621
> > --- /dev/null
> > +++ b/Documentation/vm/multigen_lru.rst
> > @@ -0,0 +1,156 @@
> > +.. SPDX-License-Identifier: GPL-2.0
> > +
> > +=============
> > +Multi-Gen LRU
> > +=============
>
> Here I also miss an introductory paragraph about what Multi-Gen LRU is.
>
> All the rest looks good to me.

Will add one in the next spin. Thanks.