Re: [PATCH v7] drivers: ddcci: upstream DDCCI driver

[Greg KH]

On Fri, Mar 11, 2022 at 02:45:01AM -0800, Joe Perches wrote:
> On Fri, 2022-03-11 at 09:14 +0100, Greg KH wrote:
> > On Thu, Mar 10, 2022 at 11:44:13PM -0800, Yusuf Khan wrote:
> > > This patch upstreams the DDCCI driver by Christoph Grenz into
> > > the kernel. The original gitlab page is loacted at https://gitlab
> > > .com/ddcci-driver-linux/ddcci-driver-linux/-/tree/master.
> []
> > > diff --git a/drivers/char/ddcci.c b/drivers/char/ddcci.c
> []
> > > @@ -0,0 +1,1887 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + *  DDC/CI sub-bus driver
> > > + *
> > > + *  Copyright (c) 2015 Christoph Grenz
> > > + */
> > > +
> > > +/*
> > > + * This program is free software; you can redistribute it and/or modify it
> > > + * under the terms of the GNU General Public License as published by the Free
> > > + * Software Foundation; either version 2 of the License, or (at your option)
> > > + * any later version.
> > 
> > This does not match the SPDX line.  Please fix up first before going any
> > further.
> 
> Which means fix up the SPDX line above to use the actual
> license of the code.
> 
> // SPDX-License-Identifier: GPL-2.0-or-later

If that is the intent, it depends on the original author, I have not
seen the source for where this came from, have you?

thanks,

greg k-h