Re: [PATCH v2 10/38] media: platform: place Renesas drivers on a separate dir

[Geert Uytterhoeven]

Hi Mauro,

On Fri, Mar 11, 2022 at 3:08 PM Mauro Carvalho Chehab
<mchehab@xxxxxxxxxx> wrote:
> In order to cleanup the main platform media directory, move Renesas
> driver to its own directory.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> ---
>
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v2 00/38] at: https://lore.kernel.org/all/cover.1647006877.git.mchehab@xxxxxxxxxx/
>
>  MAINTAINERS                                   |  16 +--
>  drivers/media/platform/Kconfig                | 113 +----------------
>  drivers/media/platform/Makefile               |   9 +-
>  drivers/media/platform/renesas/Kconfig        | 119 ++++++++++++++++++
>  drivers/media/platform/renesas/Makefile       |  14 +++
>  .../media/platform/{ => renesas}/rcar-fcp.c   |   0
>  .../media/platform/{ => renesas}/rcar-isp.c   |   0
>  .../platform/{ => renesas}/rcar-vin/Kconfig   |   0
>  .../platform/{ => renesas}/rcar-vin/Makefile  |   0
>  .../{ => renesas}/rcar-vin/rcar-core.c        |   0
>  .../{ => renesas}/rcar-vin/rcar-csi2.c        |   0
>  .../{ => renesas}/rcar-vin/rcar-dma.c         |   0
>  .../{ => renesas}/rcar-vin/rcar-v4l2.c        |   0
>  .../{ => renesas}/rcar-vin/rcar-vin.h         |   0
>  .../media/platform/{ => renesas}/rcar_drif.c  |   0
>  .../media/platform/{ => renesas}/rcar_fdp1.c  |   0
>  .../media/platform/{ => renesas}/rcar_jpu.c   |   0
>  .../platform/{ => renesas}/renesas-ceu.c      |   0
>  drivers/media/platform/{ => renesas}/sh_vou.c |   0
>  19 files changed, 144 insertions(+), 127 deletions(-)
>  create mode 100644 drivers/media/platform/renesas/Kconfig
>  create mode 100644 drivers/media/platform/renesas/Makefile
>  rename drivers/media/platform/{ => renesas}/rcar-fcp.c (100%)
>  rename drivers/media/platform/{ => renesas}/rcar-isp.c (100%)
>  rename drivers/media/platform/{ => renesas}/rcar-vin/Kconfig (100%)
>  rename drivers/media/platform/{ => renesas}/rcar-vin/Makefile (100%)
>  rename drivers/media/platform/{ => renesas}/rcar-vin/rcar-core.c (100%)
>  rename drivers/media/platform/{ => renesas}/rcar-vin/rcar-csi2.c (100%)
>  rename drivers/media/platform/{ => renesas}/rcar-vin/rcar-dma.c (100%)
>  rename drivers/media/platform/{ => renesas}/rcar-vin/rcar-v4l2.c (100%)
>  rename drivers/media/platform/{ => renesas}/rcar-vin/rcar-vin.h (100%)
>  rename drivers/media/platform/{ => renesas}/rcar_drif.c (100%)
>  rename drivers/media/platform/{ => renesas}/rcar_fdp1.c (100%)
>  rename drivers/media/platform/{ => renesas}/rcar_jpu.c (100%)
>  rename drivers/media/platform/{ => renesas}/renesas-ceu.c (100%)
>  rename drivers/media/platform/{ => renesas}/sh_vou.c (100%)

Looks like you missed the vsp1 driver code and its entry in the
MAINTAINERS file...

> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig

> -
> -config VIDEO_RENESAS_VSP1
> -       tristate "Renesas VSP1 Video Processing Engine"
> -       depends on V4L_MEM2MEM_DRIVERS
> -       depends on VIDEO_V4L2
> -       depends on ARCH_RENESAS || COMPILE_TEST
> -       depends on (!ARM64 && !VIDEO_RENESAS_FCP) || VIDEO_RENESAS_FCP
> -       select MEDIA_CONTROLLER
> -       select VIDEO_V4L2_SUBDEV_API
> -       select VIDEOBUF2_DMA_CONTIG
> -       select VIDEOBUF2_VMALLOC
> -       help
> -         This is a V4L2 driver for the Renesas VSP1 video processing engine.
> -
> -         To compile this driver as a module, choose M here: the module
> -         will be called vsp1.
> -
>  config VIDEO_ROCKCHIP_RGA
>         tristate "Rockchip Raster 2d Graphic Acceleration Unit"
>         depends on V4L_MEM2MEM_DRIVERS

> --- /dev/null
> +++ b/drivers/media/platform/renesas/Kconfig

> +
> +config VIDEO_RENESAS_VSP1
> +       tristate "Renesas VSP1 Video Processing Engine"
> +       depends on V4L_MEM2MEM_DRIVERS
> +       depends on VIDEO_V4L2
> +       depends on ARCH_RENESAS || COMPILE_TEST
> +       depends on (!ARM64 && !VIDEO_RENESAS_FCP) || VIDEO_RENESAS_FCP
> +       select MEDIA_CONTROLLER
> +       select VIDEO_V4L2_SUBDEV_API
> +       select VIDEOBUF2_DMA_CONTIG
> +       select VIDEOBUF2_VMALLOC
> +       help
> +         This is a V4L2 driver for the Renesas VSP1 video processing engine.
> +
> +         To compile this driver as a module, choose M here: the module
> +         will be called vsp1.
> +

... but you did move its Kconfig entry.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds