Re: [PATCH 14/19] rcu/context-tracking: Move RCU-dynticks internal functions to context_tracking

From: Paul E. McKenney
Date: Fri Mar 11 2022 - 11:14:50 EST


On Fri, Mar 11, 2022 at 05:02:39PM +0100, Frederic Weisbecker wrote:
> On Thu, Mar 10, 2022 at 12:07:05PM -0800, Paul E. McKenney wrote:
> > On Wed, Mar 02, 2022 at 04:48:05PM +0100, Frederic Weisbecker wrote:
> > > Move the core RCU eqs/dynticks functions to context tracking so that
> > > we can later merge all that code within context tracking.
> > >
> > > Signed-off-by: Frederic Weisbecker <frederic@xxxxxxxxxx>
> >
> > I am not sure that you want rcu_dynticks_task_enter() and friends in
> > context tracking, but I have no objection to them living there. ;-)
>
> I initially tried to keep them in RCU headers but their use of "current"
> would imply a circular dependency with sched.h.
>
> Not much appealing alternatives could be:
>
> * macrofying them
> * uninline them and keep in RCU
>
> ...

Sounds like good reasons for them to live outside of kernel/rcu.

Thanx, Paul