Re: [PATCH v4 16/24] EDAC/amd64: Define function to make space for CS ID

[Borislav Petkov]

On Wed, Mar 09, 2022 at 10:25:22PM +0000, Yazen Ghannam wrote:
> I guess this could be "addr = func(x, y, addr)", but why not just operate on
> the value directly? There isn't an error condition here that's obvious to me.

Because when you look at the callsite:

	ctx->make_space_for_cs_id(ctx);

and compare it with the version I'm suggesting:

	ctx->ret_addr = ctx->add_coherent_slave_id_slice(ctx);

my version says exactly what it does: it adds the bit slice of CS ID to
ret_addr. You don't even have to look at the function body in order to
know what's going on.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette