Re: [PATCH] sparc: vDSO: fix return value of __setup handler

From: Dan Carpenter
Date: Sat Mar 12 2022 - 02:07:54 EST


On Fri, Mar 11, 2022 at 08:21:44PM -0800, Randy Dunlap wrote:
> __setup() handlers should return 1 to obsolete_checksetup() in
> init/main.c to indicate that the boot option has been handled.
> A return of 0 causes the boot option/value to be listed as an Unknown
> kernel parameter and added to init's (limited) argument or environment
> strings. Also, error return codes don't mean anything to
> obsolete_checksetup() -- only non-zero (usually 1) or zero.
> So return 1 from vdso_setup().
>
> Fixes: 62d6f3b7b85e ("sparc: vDSO: Silence an uninitialized variable warning")

This fixes tag is wrong. My patch did not change the return values at
all.

regards,
dan carpenter