Re: [PATCH v2 21/38] media: platform: camss: move config to its own file

From: Robert Foss
Date: Sat Mar 12 2022 - 05:09:42 EST


On Fri, 11 Mar 2022 at 15:09, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> wrote:
>
> In order to better organize the platform/Kconfig, place
> camss-specific config stuff on a separate Kconfig file.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> ---
>
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v2 00/38] at: https://lore.kernel.org/all/cover.1647006877.git.mchehab@xxxxxxxxxx/
>
> drivers/media/platform/Kconfig | 11 +----------
> drivers/media/platform/qcom/camss/Kconfig | 9 +++++++++
> 2 files changed, 10 insertions(+), 10 deletions(-)
> create mode 100644 drivers/media/platform/qcom/camss/Kconfig
>
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index f65eefa15dda..19ca01d2f841 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -61,6 +61,7 @@ source "drivers/media/platform/mtk-vcodec/Kconfig"
> source "drivers/media/platform/mtk-vpu/Kconfig"
> source "drivers/media/platform/omap3isp/Kconfig"
> source "drivers/media/platform/omap/Kconfig"
> +source "drivers/media/platform/qcom/camss/Kconfig"
>
> source "drivers/media/platform/aspeed/Kconfig"
>
> @@ -78,16 +79,6 @@ config VIDEO_MUX
>
> source "drivers/media/platform/intel/Kconfig"
>
> -config VIDEO_QCOM_CAMSS
> - tristate "Qualcomm V4L2 Camera Subsystem driver"
> - depends on V4L_PLATFORM_DRIVERS
> - depends on VIDEO_V4L2
> - depends on (ARCH_QCOM && IOMMU_DMA) || COMPILE_TEST
> - select MEDIA_CONTROLLER
> - select VIDEO_V4L2_SUBDEV_API
> - select VIDEOBUF2_DMA_SG
> - select V4L2_FWNODE
> -
> config VIDEO_S3C_CAMIF
> tristate "Samsung S3C24XX/S3C64XX SoC Camera Interface driver"
> depends on V4L_PLATFORM_DRIVERS
> diff --git a/drivers/media/platform/qcom/camss/Kconfig b/drivers/media/platform/qcom/camss/Kconfig
> new file mode 100644
> index 000000000000..56be91578706
> --- /dev/null
> +++ b/drivers/media/platform/qcom/camss/Kconfig
> @@ -0,0 +1,9 @@
> +config VIDEO_QCOM_CAMSS
> + tristate "Qualcomm V4L2 Camera Subsystem driver"
> + depends on V4L_PLATFORM_DRIVERS
> + depends on VIDEO_V4L2
> + depends on (ARCH_QCOM && IOMMU_DMA) || COMPILE_TEST
> + select MEDIA_CONTROLLER
> + select VIDEO_V4L2_SUBDEV_API
> + select VIDEOBUF2_DMA_SG
> + select V4L2_FWNODE
> --
> 2.35.1
>

Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx>