Re: [RESEND V2] ASoC: max98390: Add reset gpio control

[Krzysztof Kozlowski]

On 12/03/2022 01:24, Steve Lee wrote:
>  Add reset gpio control to support RESET PIN connected to gpio.
> 
> Signed-off-by: Steve Lee <steve.lee.analog@xxxxxxxxx>
> ---
>  sound/soc/codecs/max98390.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c
> index 40fd6f363f35..9a9299e5cc5a 100644
> --- a/sound/soc/codecs/max98390.c
> +++ b/sound/soc/codecs/max98390.c
> @@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct i2c_client *i2c,
>  
>  	struct max98390_priv *max98390 = NULL;
>  	struct i2c_adapter *adapter = i2c->adapter;
> +	struct gpio_desc *reset_gpio;
>  
>  	ret = i2c_check_functionality(adapter,
>  		I2C_FUNC_SMBUS_BYTE
> @@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct i2c_client *i2c,
>  		return ret;
>  	}
>  
> +	reset_gpio = devm_gpiod_get_optional(&i2c->dev,
> +					     "maxim,reset-gpios", GPIOD_OUT_LOW);
> +

I don't know why did you CC me, but since I am looking at this - you
have to update bindings.

Do not add random properties to drivers without updating bindings.

Best regards,
Krzysztof