Re: [RFC PATCH v5 006/104] KVM: TDX: Add placeholders for TDX VM/vcpu structure

From: Paolo Bonzini
Date: Sun Mar 13 2022 - 09:55:54 EST


On 3/4/22 20:48, isaku.yamahata@xxxxxxxxx wrote:
+void __init tdx_pre_kvm_init(unsigned int *vcpu_size,
+ unsigned int *vcpu_align, unsigned int *vm_size)
+{
+ *vcpu_size = sizeof(struct vcpu_tdx);
+ *vcpu_align = __alignof__(struct vcpu_tdx);
+
+ if (sizeof(struct kvm_tdx) > *vm_size)
+ *vm_size = sizeof(struct kvm_tdx);
+}

No need for this function, I would just do

vcpu_size = max(sizeof vcpu_vmx, sizeof vcpu_tdx);
vcpu_align = max(...);
vt_x86_ops.vm_size = max(...);

in vt_init.

Paolo