Re: [PATCH 1/1] vhost: Protect the virtqueue from being cleared whilst still in use
From: Greg KH
Date: Mon Mar 14 2022 - 04:56:27 EST
On Mon, Mar 14, 2022 at 08:43:02AM +0000, Lee Jones wrote:
> vhost_vsock_handle_tx_kick() already holds the mutex during its call
> to vhost_get_vq_desc(). All we have to do here is take the same lock
> during virtqueue clean-up and we mitigate the reported issues.
>
> Also WARN() as a precautionary measure. The purpose of this is to
> capture possible future race conditions which may pop up over time.
These two sentances do not match your actual patch :(
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
What commit caused this problem? Can you add a Fixes: line as well for
this?
thanks,
greg k-h