RE: [PATCH] thermal: int340x: Increase bitmap size

From: David Laight
Date: Mon Mar 14 2022 - 11:29:07 EST


From: Srinivas Pandruvada
> Sent: 14 March 2022 14:50
>
> The number of policies are 10, so can't be supported by the bitmap size
> of u8. Even though there are no platfoms with these many policies, but
> as correctness increase to u16.

You might as well just use 'unsigned int'.
May generate better code and there is still padding
in the structure.

David

>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> Fixes: 16fc8eca1975 ("thermal/int340x_thermal: Add additional UUIDs")
> Cc: stable@xxxxxxxxxxxxxxx
> ---
> drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> index 72acb1f61849..c2d3df302214 100644
> --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> @@ -53,7 +53,7 @@ struct int3400_thermal_priv {
> struct art *arts;
> int trt_count;
> struct trt *trts;
> - u8 uuid_bitmap;
> + u16 uuid_bitmap;
> int rel_misc_dev_res;
> int current_uuid_index;
> char *data_vault;
> --
> 2.31.1

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)