Re: [PATCH 0/6] staging: r8188eu: some rx cleanups

From: Greg Kroah-Hartman
Date: Mon Mar 14 2022 - 13:31:29 EST


On Sat, Mar 05, 2022 at 07:53:45PM +0100, Martin Kaiser wrote:
> Here's another set with simple cleanups in the code for receiving frames.
>
> Martin Kaiser (6):
> staging: r8188eu: remove unnecessary initializations
> staging: r8188eu: remove three unused receive defines
> staging: r8188eu: remove unused function prototype
> staging: r8188eu: make rtl8188e_process_phy_info static
> staging: r8188eu: remove some unused local ieee80211 macros
> staging: r8188eu: remove local BIT macro
>
> drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c | 6 +---
> .../staging/r8188eu/include/rtl8188e_recv.h | 6 ----
> drivers/staging/r8188eu/include/wifi.h | 34 +------------------
> 3 files changed, 2 insertions(+), 44 deletions(-)
>
> --
> 2.30.2
>
>

This series breaks the build:

drivers/staging/r8188eu/core/rtw_wlan_util.c: In function ‘update_IOT_info’:
drivers/staging/r8188eu/core/rtw_wlan_util.c:1279:42: error: conversion from ‘long unsigned int’ to ‘u32’ {aka ‘unsigned int’} changes value from ‘18446744073709551611’ to ‘4294967291’ [-Werror=overflow]
1279 | Switch_DM_Func(padapter, (~DYNAMIC_BB_DYNAMIC_TXPWR), false);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging/r8188eu/core/rtw_wlan_util.c:1285:42: error: conversion from ‘long unsigned int’ to ‘u32’ {aka ‘unsigned int’} changes value from ‘18446744073709551611’ to ‘4294967291’ [-Werror=overflow]
1285 | Switch_DM_Func(padapter, (~DYNAMIC_BB_DYNAMIC_TXPWR), false);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

I'm going to drop it from my queue now.

thanks,

greg k-h