Re: [PATCH v2] vfio-pci: Provide reviewers and acceptance criteria for vendor drivers

From: Alex Williamson
Date: Mon Mar 14 2022 - 15:53:48 EST


Hi Jon,

On Mon, 14 Mar 2022 13:42:51 -0600
Jonathan Corbet <corbet@xxxxxxx> wrote:

> Alex Williamson <alex.williamson@xxxxxxxxxx> writes:
>
> > Vendor or device specific extensions for devices exposed to userspace
> > through the vfio-pci-core library open both new functionality and new
> > risks. Here we attempt to provided formalized requirements and
> > expectations to ensure that future drivers both collaborate in their
> > interaction with existing host drivers, as well as receive additional
> > reviews from community members with experience in this area.
> >
> > Cc: Jason Gunthorpe <jgg@xxxxxxxxxx>
> > Cc: Yishai Hadas <yishaih@xxxxxxxxxx>
> > Cc: Shameer Kolothum <shameerali.kolothum.thodi@xxxxxxxxxx>
> > Cc: Kevin Tian <kevin.tian@xxxxxxxxx>
> > Signed-off-by: Alex Williamson <alex.williamson@xxxxxxxxxx>
> > ---
>
> One thing...
>
> > .../vfio/vfio-pci-vendor-driver-acceptance.rst | 35 ++++++++++++++++++++
> > MAINTAINERS | 10 ++++++
> > 2 files changed, 45 insertions(+)
>
> If you add a new RST file, you need to add it to an index.rst somewhere
> so that it becomes part of the kernel docs build.

Whoops

> Also, though: can we avoid creating a new top-level documentation
> directory for just this file? It seems like it would logically be a
> part of the maintainers guide (Documentation/maintainer) ... ?

I'm not sure it's appropriate for Documentation/maintainer/ but it
would make sense to link it from maintainer-entry-profile.rst there.
What if I move it to Documentation/driver-api where there are a couple
other vfio docs? Thanks,

Alex