RE: [PATCH] ARM: dts: exynos: drop deprecated SFR region from MIPI phy

[Alim Akhtar]

Hi Krzysztof,

>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxxxxx]
>Sent: Tuesday, March 15, 2022 12:11 AM
>To: Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
><krzk+dt@xxxxxxxxxx>; Alim Akhtar <alim.akhtar@xxxxxxxxxxx>;
>devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
>samsung-soc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>Cc: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>; Sylwester Nawrocki
><snawrocki@xxxxxxxxxx>; Krzysztof Kozlowski
><krzysztof.kozlowski@xxxxxxxxxxxxx>
>Subject: [PATCH] ARM: dts: exynos: drop deprecated SFR region from MIPI
>phy
>
>Commit e4b3d38088df ("phy: exynos-video-mipi: Fix regression by adding
>support for PMU regmap") deprecated the usage of unit address in MIPI phy
>node, in favor of a syscon phandle.  Deprecating was a correct approach
>because that unit address was actually coming from Power Management Unit
>SFR range so its usage here caused overlapped memory mapping.
>
>In 2016 commit 26dbadba495f ("phy: exynos-mipi-video: Drop support for
>direct access to PMU") fully removed support for parsing that MIPI phy unit
>address (SFR range) but the address stayed in Exynos5250 DTSI for
>compatibility reasons.
>
>Remove that deprecated unit address from Exynos5250 MIPI phy, because it
>has been almost 6 years since it was deprecated and it causes now DT schema
>validation warnings:
>
>  video-phy@10040710: 'reg' does not match any of the regexes: 'pinctrl-[0-
>9]+'
>
>Any out-of-tree users of Exynos5250 DTSI, should update their code to use
>newer syscon property.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
>---

Reviewed-by: Alim Akhtar<alim.akhtar@xxxxxxxxxxx>

> arch/arm/boot/dts/exynos5250.dtsi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>b/arch/arm/boot/dts/exynos5250.dtsi
>index 5baaa7eb71a4..d8d401b5ca48 100644
>--- a/arch/arm/boot/dts/exynos5250.dtsi
>+++ b/arch/arm/boot/dts/exynos5250.dtsi
>@@ -817,15 +817,14 @@ mixer: mixer@14450000 {
> 			status = "disabled";
> 		};
>
>-		dp_phy: video-phy {
>+		dp_phy: video-phy-0 {
> 			compatible = "samsung,exynos5250-dp-video-phy";
> 			samsung,pmu-syscon = <&pmu_system_controller>;
> 			#phy-cells = <0>;
> 		};
>
>-		mipi_phy: video-phy@10040710 {
>+		mipi_phy: video-phy-1 {
> 			compatible = "samsung,s5pv210-mipi-video-phy";
>-			reg = <0x10040710 0x100>;
> 			#phy-cells = <1>;
> 			syscon = <&pmu_system_controller>;
> 		};
>--
>2.32.0