Re: [PATCH 1/2] dt-bindings: mfd: Add ChromeOS fingerprint binding
From: Tzung-Bi Shih
Date: Mon Mar 14 2022 - 23:08:58 EST
On Mon, Mar 14, 2022 at 04:22:13PM -0700, Stephen Boyd wrote:
> Add a binding to describe the fingerprint processor found on Chromeboks
> with a fingerprint sensor.
Nit: s/Chromeboks/Chromebooks/.
> +properties:
> + compatible:
> + const: google,cros-ec-fp
Not sure if it could make sense for FPS with other interfaces: would
cros-ec-fp-spi or cros-ec-spi-fp be a better name? I am wondering because
there are cros-ec-spi specific properties "google,cros-ec-spi-pre-delay" and
"google,cros-ec-spi-msg-delay" in the binding.
> + reset-gpios:
> + maxItems: 1
> + description: reset signal (active low).
> +
> + boot0-gpios:
> + maxItems: 1
> + description: boot signal (low for normal boot; high for bootloader).
> +
> + vdd-supply:
> + description: Power supply for the fingerprint controller.
To be consistent: s/Power/power/.