Re: [PATCH] scsi: scsi_ioctl:drop needless assignment in sg_io()

[Christoph Hellwig]

On Tue, Mar 15, 2022 at 07:15:20AM +0100, Lukas Bulwahn wrote:
> Commit ce70fd9a551a ("scsi: core: Remove the cmd field from struct
> scsi_request") refactored sg_io(), so that it does not allocate directly
> and hence does not return -ENOMEM in its error case. That makes a
> remaining assignment of -ENOMEM to the return variable needless.
> 
> Drop this needless assignment in sg_io().
> 
> No functional change. No change in resulting object code.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>

Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>