Re: [RFC PATCH v1 1/3] af_vsock: add two new tests for SOCK_SEQPACKET

[Stefano Garzarella]

Hi Arseniy,

On Fri, Mar 11, 2022 at 10:52:36AM +0000, Krasnov Arseniy Vladimirovich wrote:
> This adds two tests: for receive timeout and reading to invalid
> buffer provided by user. I forgot to put both patches to main
> patchset.
>
> Arseniy Krasnov(2):
>
> af_vsock: SOCK_SEQPACKET receive timeout test
> af_vsock: SOCK_SEQPACKET broken buffer test
>
> tools/testing/vsock/vsock_test.c | 170 +++++++++++++++++++++++++++++++++++++++
> 1 file changed, 170 insertions(+)

Thank you for these tests!

I left a few comments and I'm not sure about the 'broken buffer test' 
behavior.

About the series, it sounds like something is wrong with your setup, 
usually the cover letter is "patch" 0. In this case I would have 
expected:

    [0/2] af_vsock: add two new tests for SOCK_SEQPACKET
    [1/2] af_vsock: SOCK_SEQPACKET receive timeout test
    [2/2] af_vsock: SOCK_SEQPACKET broken buffer test

Are you using `git send-email` or `git publish`?


When you will remove the RFC, please add `net-next` label:
[PATCH net-next 0/2], etc..

Thanks,
Stefano