Re: [PATCH -next] powerpc/eeh: Add correct inline functions

[Christophe Leroy]

Le 31/03/2021 à 14:53, YueHaibing a écrit :
> pseries_eeh_add_device_early()/pseries_eeh_add_device_tree_early() is
> never used since adding, however pseries_eeh_init_edev() and
> pseries_eeh_init_edev_recursive() need their inline versions.
>
> Fixes: b6eebb093cad ("powerpc/eeh: Make early EEH init pseries specific")
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Those inline are not needed at all:
- pseries_eeh_init_edev_recursive() is only called from files build wich 
CONFIG_HOTPLUG_PCI_RPA which depends on CONFIG_PSERIES and CONFIG_EEH
- pseries_eeh_init_edev() is used exclusively in
arch/powerpc/platforms/pseries/eeh_pseries.c and should be made static.

Can you update your patch ?

Thanks
Christophe

> ---
>   arch/powerpc/include/asm/eeh.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h
> index b1a5bba2e0b9..0b6c2a6711d3 100644
> --- a/arch/powerpc/include/asm/eeh.h
> +++ b/arch/powerpc/include/asm/eeh.h
> @@ -357,8 +357,8 @@ static inline int eeh_phb_pe_create(struct pci_controller *phb) { return 0; }
>   void pseries_eeh_init_edev(struct pci_dn *pdn);
>   void pseries_eeh_init_edev_recursive(struct pci_dn *pdn);
>   #else
> -static inline void pseries_eeh_add_device_early(struct pci_dn *pdn) { }
> -static inline void pseries_eeh_add_device_tree_early(struct pci_dn *pdn) { }
> +static inline void pseries_eeh_init_edev(struct pci_dn *pdn) { }
> +static inline void pseries_eeh_init_edev_recursive(struct pci_dn *pdn) { }
>   #endif
>   
>   #ifdef CONFIG_PPC64