Re: [EXT] Re: [PATCH] Uwb: Nxp: sr1xx: Uwb driver support for sr1xx series chip

[Greg KH]

On Tue, Mar 15, 2022 at 10:43:47AM +0000, Manjunatha Venkatesh wrote:
> >> +     sr1xx_dev = filp->private_data;
> >> +     switch (cmd) {
> >> +     case SR1XX_SET_PWR:
> > You have custom ioctls on a device node, that's not very "subsystem"
> > like at all.
> >
> > You need to define a standard user/kernel api for this subsystem, do not
> > make it "whatever the device wants" like this currently is.
> >
> > And where is the userspace code that talks this brand new api?  We need
> > to see that so we can properly determine if this is all working
> > properly.
> Currently these ioctl calls used for handling proprietary operation with 
> respect to SR1xx chip.
> corresponding user space UWB code is proprietary and might be shortly 
> will be available as part of AOSP release, till that time not sure can 
> share user space code outside or not.
> Still if you think need the user space code required to evaluate driver 
> part will check internally and come back on this.

For obvious reasons, we can not take kernel drivers that add a custom
user/kernel api without any userspace code that we can see to use it.
You wouldn't want us to take such code anyway.

So please, fix that, otherwise this is not going to go very far at all.

thanks,

greg k-h