Re: [PATCH] sched: dynamic config sd_flags if described in DT

[kernel test robot]

Hi Qing,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on driver-core/driver-core-testing tip/sched/core linus/master v5.17-rc8 next-20220310]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Qing-Wang/sched-dynamic-config-sd_flags-if-described-in-DT/20220315-160039
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: riscv-randconfig-r025-20220314 (https://download.01.org/0day-ci/archive/20220315/202203152145.vPr4Qv42-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project a6b2f50fb47da3baeee10b1906da6e30ac5d26ec)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://github.com/0day-ci/linux/commit/3322560249c42b0a3e719b19842a3ace7d5ffb6a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Qing-Wang/sched-dynamic-config-sd_flags-if-described-in-DT/20220315-160039
        git checkout 3322560249c42b0a3e719b19842a3ace7d5ffb6a
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/base/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/base/arch_topology.c:648:23: error: use of undeclared identifier 'cpu'
                   if (!cache_topology[cpu][cache_level])
                                       ^
   drivers/base/arch_topology.c:654:23: error: use of undeclared identifier 'cpu'
                           if (cache_topology[cpu][cache_level] == cache_topology[cpu_id][cache_level]) {
                                              ^
   2 errors generated.


vim +/cpu +648 drivers/base/arch_topology.c

   639	
   640	int cpus_share_self_cache(const struct cpumask *cpu_map)
   641	{
   642		int cache_level, cpu_id;
   643		int first, last;
   644		int id = cpumask_first(cpu_map);
   645		int size = cpumask_weight(cpu_map);
   646	
   647		for (cache_level = 0; cache_level < MAX_CACHE_LEVEL; cache_level++) {
 > 648			if (!cache_topology[cpu][cache_level])
   649				return -1;
   650	
   651			first = -1;
   652			last = id;
   653			for (cpu_id = 0; cpu_id < NR_CPUS; cpu_id++) {
   654				if (cache_topology[cpu][cache_level] == cache_topology[cpu_id][cache_level]) {
   655					if (cpu_id < id || cpu_id >= id + size)
   656						return 0;
   657	
   658					first = (first == -1)?cpu_id:first;
   659					last = cpu_id;
   660				}
   661			}
   662	
   663			if (first == id && last == id + size)
   664				return 1;
   665		}
   666	
   667		return 0;
   668	}
   669	

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx