Re: [PATCH v3 16/21] arm64: dts: mt8192: Add vcodec lat and core nodes

[AngeloGioacchino Del Regno]

Il 04/03/22 14:08, Allen-KH Cheng ha scritto:
> Add vcodec lat and core nodes for mt8192 SoC.
>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@xxxxxxxxxxxx>
> ---
>   arch/arm64/boot/dts/mediatek/mt8192.dtsi | 58 ++++++++++++++++++++++++
>   1 file changed, 58 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> index ac69033737bb..5fd1fed354d0 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> @@ -1285,6 +1285,64 @@
>   			power-domains = <&spm MT8192_POWER_DOMAIN_ISP2>;
>   		};
>   
> +		vcodec_dec: vcodec-dec@16000000 {
> +			compatible = "mediatek,mt8192-vcodec-dec";
> +			reg = <0 0x16000000 0 0x1000>;	/* VDEC_SYS */
> +			mediatek,scp = <&scp>;
> +			iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>;

Hello Allen-KH,

please, use ranges whenever possible. Example:

			ranges = <0 0 0 0x16000000 0 0x26000>;

			vcodec-lat@1000 {
				reg = <0 0x1000 0 0x800>;
				.......

			};

			vcodec-core@25000 {
				reg = <0 0x25000 0 0x1000>;
				.......
			};

Thanks,
Angelo