Re: [PATCH v4 net-next 12/15] net: dsa: Handle MST state changes

From: Vladimir Oltean
Date: Tue Mar 15 2022 - 12:44:48 EST


On Tue, Mar 15, 2022 at 06:42:49PM +0200, Vladimir Oltean wrote:
> Is there a requirement in br_mst_set_state() to put the switchdev
> notifier at the end instead of at the beginning?
>
> I'm tempted to ask you to introduce br_mst_get_state(), then assign
> old_state = br_mst_get_state(dsa_port_bridge_dev_get(dp), state->msti),

dsa_port_to_bridge_port(dp), excuse me.

> then perform the VLAN fast age only on the appropriate state transitions,
> just like the regular fast age.