Re: [PATCH v2] gpio: Restrict usage of gc irq members before initialization

From: Andy Shevchenko
Date: Tue Mar 15 2022 - 14:06:53 EST


On Tue, Mar 15, 2022 at 7:38 PM kernel test robot <lkp@xxxxxxxxx> wrote:
>
> Hi Shreeya,
>
> Thank you for the patch! Yet something to improve:


> All errors (new ones prefixed by >>):
>
> drivers/gpio/gpiolib.c: In function 'gpiod_to_irq':
> >> drivers/gpio/gpiolib.c:3068:29: error: 'struct gpio_chip' has no member named 'irq'
> 3068 | if (gc->to_irq && gc->irq.gc_irq_initialized) {
> | ^~

Exactly, because this check should go under ifdeffery.

--
With Best Regards,
Andy Shevchenko